[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH V7 07/19] protect TBContext with tb_lock.
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [RFC PATCH V7 07/19] protect TBContext with tb_lock. |
Date: |
Tue, 11 Aug 2015 11:59:20 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 |
On 11/08/2015 11:21, Peter Maydell wrote:
> > > I think it's definitely not sufficient. Is user-mode multithread still
> > > working today?
> >
> > For some definition of "working", yes. It's not sufficient, but it's a
> > good start.
> >
> > The main problem with user-mode multithreading is that there is no clear
> > lock hierarchy between mmap_lock and tb_lock. But this is not a problem
> > for softmmu.
>
> And also that we don't have a serious design for the locking at all.
> I was hoping this would be something that would come out of the
> multithreaded-TCG work...
Indeed. Fred made an effort to identify the translate-all.c functions
that need tb_lock, and there are only a few that need mmap_lock. I'm
now trying to document it so that the patches are actually reviewable...
Paolo
- [Qemu-devel] [RFC PATCH V7 04/19] replace spinlock by QemuMutex., (continued)
- [Qemu-devel] [RFC PATCH V7 04/19] replace spinlock by QemuMutex., fred . konrad, 2015/08/10
- [Qemu-devel] [RFC PATCH V7 07/19] protect TBContext with tb_lock., fred . konrad, 2015/08/10
- Re: [Qemu-devel] [RFC PATCH V7 07/19] protect TBContext with tb_lock., Frederic Konrad, 2015/08/11
- Re: [Qemu-devel] [RFC PATCH V7 07/19] protect TBContext with tb_lock., Paolo Bonzini, 2015/08/11
- Re: [Qemu-devel] [RFC PATCH V7 07/19] protect TBContext with tb_lock., Peter Maydell, 2015/08/11
- Re: [Qemu-devel] [RFC PATCH V7 07/19] protect TBContext with tb_lock.,
Paolo Bonzini <=
Re: [Qemu-devel] [RFC PATCH V7 07/19] protect TBContext with tb_lock., Frederic Konrad, 2015/08/12
[Qemu-devel] [RFC PATCH V7 08/19] tcg: remove tcg_halt_cond global variable., fred . konrad, 2015/08/10
[Qemu-devel] [RFC PATCH V7 09/19] Drop global lock during TCG code execution, fred . konrad, 2015/08/10