Re: [Qemu-devel] [PATCH v2 2/6] hw/virtio/virtio-pci: Use pow2ceil() rather than hand-calculation

[Michael S. Tsirkin]

On Fri, Jul 24, 2015 at 01:33:08PM +0100, Peter Maydell wrote:
> Use the utility function pow2ceil() for rounding up to the next
> largest power of 2, rather than inline calculation.
> 
> Signed-off-by: Peter Maydell <address@hidden>

Reviewed-by: Michael S. Tsirkin <address@hidden>

> ---
>  hw/virtio/virtio-pci.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c
> index 283401a..845f52f 100644
> --- a/hw/virtio/virtio-pci.c
> +++ b/hw/virtio/virtio-pci.c
> @@ -1497,9 +1497,7 @@ static void virtio_pci_device_plugged(DeviceState *d, 
> Error **errp)
>      if (legacy) {
>          size = VIRTIO_PCI_REGION_SIZE(&proxy->pci_dev)
>              + virtio_bus_get_vdev_config_len(bus);
> -        if (size & (size - 1)) {
> -            size = 1 << qemu_fls(size);
> -        }
> +        size = pow2ceil(size);
>  
>          memory_region_init_io(&proxy->bar, OBJECT(proxy),
>                                &virtio_pci_config_ops,
> -- 
> 1.9.1