[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Xen-devel] [PATCH v1] xenpt: Properly handle 64-bit ba
|
From: |
Jan Beulich |
|
Subject: |
Re: [Qemu-devel] [Xen-devel] [PATCH v1] xenpt: Properly handle 64-bit bar with more than 4G size |
|
Date: |
Wed, 12 Aug 2015 02:43:23 -0600 |
>>> On 12.08.15 at 09:10, <address@hidden> wrote:
>
>> -----Original Message-----
>> From: address@hidden
>> [mailto:address@hidden On Behalf Of
>> Jan Beulich
>> Sent: Wednesday, August 12, 2015 2:59 PM
>> To: Wu, Feng
>> Cc: address@hidden; address@hidden;
>> address@hidden
>> Subject: Re: [Qemu-devel] [Xen-devel] [PATCH v1] xenpt: Properly handle
>> 64-bit
>> bar with more than 4G size
>>
>> >>> On 05.08.15 at 04:02, <address@hidden> wrote:
>> > @@ -491,8 +474,9 @@ static int
>> xen_pt_bar_reg_write(XenPCIPassthroughState *s, XenPTReg *cfg_entry,
>> > bar_ro_mask = XEN_PT_BAR_IO_RO_MASK | (r_size - 1);
>> > break;
>> > case XEN_PT_BAR_FLAG_UPPER:
>> > + r = &d->io_regions[index-1];
>>
>> Perhaps worth an assert(index > 0)?
>
> No problem, I will add it. BTW, do you have any other comments about this
> patch? If no, I am
> going to send out the new version with this changes.
No - everything else looks to make sense (but continues to need
testing).
Jan