Re: [Qemu-devel] [PATCH for-2.5 16/30] m68k: Add all access modes and data sizes to some 680x0 instructions

[Richard Henderson]

On 08/09/2015 01:13 PM, Laurent Vivier wrote:
>      case 6: /* cmpi */
>          tcg_gen_mov_i32(dest, src1);
>          tcg_gen_subi_i32(dest, dest, im);
>          gen_update_cc_add(dest, tcg_const_i32(im));
> -        set_cc_op(s, CC_OP_SUB);
> +        SET_CC_OP(opsize, SUB);
>          break;
>      default:
>          abort();
>      }
> -    if (op != 6) {
> -        DEST_EA(env, insn, OS_LONG, dest, &addr);
> -    }
> +    DEST_EA(env, insn, opsize, dest, &addr);

It appears you've lost the if that doesn't write back the result of compare.
Did you intend to change the case 6 break to a return?


r~