Re: [Qemu-devel] [PATCH for-2.5 16/30] m68k: Add all access modes and data sizes to some 680x0 instructions

[Richard Henderson]

On 08/09/2015 01:13 PM, Laurent Vivier wrote:
> -        SRC_EA(env, tmp, OS_LONG, 0, &addr);
> +        SRC_EA(env, tmp, opsize, -1, &addr);

Oh, I'm also wondering why you changed all of the inputs from unsigned to
signed.  It appears to be unrelated to updating the modes, and unnecessary.

I'm all for reducing churn and doing both at once, so long as you say why.  But
at present it looks like a mistake.


r~