|
| From: | Peter Maydell |
| Subject: | Re: [Qemu-devel] [PULL 00/20] SCSI, build, TCG, RCU, misc patches for 2015-08-12 |
| Date: | Thu, 13 Aug 2015 10:43:28 +0100 |
On 13 August 2015 at 10:37, Paolo Bonzini <address@hidden> wrote: > > > On 13/08/2015 11:28, Peter Maydell wrote: >> config-host.mak is out-of-date, running configure >> ../../configure: 2789: local: -I/usr/include/glib-2.0: bad variable name >> >> line 2789 is >> local probe_cflags=$($pkg_config --cflags $1) >> >> 'local' isn't part of POSIX shell. It is supported by 'dash', but >> only in the form 'local varname ...', not the bash-specific >> 'local varname=value ...' form. > > This is not entirely correct; dash is clearly supporting assignments in > local as well; we have: > > local compiler="$1" The dash manpage doesn't document that it supports var=value. https://wiki.ubuntu.com/DashAsBinSh#local suggests that it's probably safest to just have 'local' do the declaration part only and one variable per line, though. But we have a lot of places in configure which avoid local and instead have variables named 'local_foo' too. -- PMM
| [Prev in Thread] | Current Thread | [Next in Thread] |