Re: [Qemu-devel] [PATCH v8 5/5] Add gicversion option to virt machine

[Pavel Fedin]

 Hello!

 I am now finishing v9 and (i hope) i fixed everything except this one. Sorry, 
too many mails, i occasionally skipped this one earlier.

> Any particular reason for having two separate VIRT_ITS_*
> entries? The spec mandates that the two 64K pages of ITS
> have to be consecutive, so it would make life easier for
> boards if they were just a single memory region.

 Yes, there is a reason. It is because of how in-kernel vITS works. It handles 
only control region. Translation register has to be handled in userspace and 
writes there need to be converted to KVM_SIGNAL_MSI ioctl. Therefore two 
regions are more convenient to use.

Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia