Re: [Qemu-devel] Win32 stdio not working if SDL is enabled

[Daniel P. Berrange]

On Thu, Aug 13, 2015 at 01:06:43PM +0100, Daniel P. Berrange wrote:
> When debugging some patches on Windows, I discovered that nothing printed
> to stderr ever appears on the console. Eventually I discovered that if I
> build with --disable-sdl, then stderr appears just fine.
> 
> Looking at the code in vl.c I see a hack for SDL introduced in
> 
>   commit 59a36a2f6728081050afc6ec97d0018467999f79
>   Author: Stefan Weil <address@hidden>
>   Date:   Thu Jun 18 20:11:03 2009 +0200
> 
>     Win32: Fix compilation with SDL.
> 
> 
> If I mostly kill the hack from vl.c, and just leave a plain '#undef main'
> then I get working console stderr once again.

[snip]

> to get it to print an error about bad -object arg. The message
> never appears unless I apply that patch above, though I lack any
> explanation as to why this is happening, aside from "SDL black magic"

So I figured out what's going on here

The sdl-config program is adding "-Dmain=SDL_main" to the compiler flags.
So when vl.c does this:

  #include <SDL.h>
  int qemu_main(int argc, char **argv, char **envp);
  int main(int argc, char **argv)
  {
      return qemu_main(argc, argv, NULL);
  }
  #undef main
  #define main qemu_main

We have an extra level of substitution going on. So we end up
the program starting in a

   main(int argc, char **argv)

that is provided by SDL.dll, which in turn calls this stub
we define at the top of vl.c:

  int main(int argc, char **argv)
  {
      return qemu_main(argc, argv, NULL);
  }

where 'main' is actually changed to 'SDL_main', and 'qemu_main'
is auctally the real 'main' at the bottom of vl.c

Looking in SDL sources, one of the things it does in its replacement
main() method is to kill off default stdout & stderr streams,
replacing them with a stream that writes data to stdout.txt and
stderr.txt in the current directory.

As well as breaking the ability to see error messages on stderr,
this stupid SDL redirection also breaks the ability to use the
monitor via '-monitor stdio'.

All this is done even if you are not actually using SDL as the
QEMU display output too.

By replacing that current hack:

  #include <SDL.h>
  int qemu_main(int argc, char **argv, char **envp);
  int main(int argc, char **argv)
  {
      return qemu_main(argc, argv, NULL);
  }
  #undef main
  #define main qemu_main

With just

 #include <SDL.h>
 #undef main

we get rid of SDL.dll's replacement main() method entirely and execution
directly starts in QEMU's main() from vl.c. This avoids the stupid
console output redirection SDL does, and AFAICT, the SDL UI still works
after this, so the other setup things SDL.dll does don't seem to be too
critical

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|