Re: [Qemu-devel] [RFC PATCH V7 11/19] tcg: switch on multithread.

[Paolo Bonzini]

On 13/08/2015 16:41, Frederic Konrad wrote:
>>>
>> One issue here is that when tcg_cpu_exec returns EXCP_HALTED, the
>> function keeps looping.  There is no need to set cpu->exit_request in
>> that case, since in fact there is no request pending, so the while loop
>> probably should be an "if".
> Nice catch thanks!
> 
> I missed the fact that it was running through the list of VCPUs and
> exited the
> for(;;) loop.
> 
> I should rework this patch a little.. Maybe it's better to keep this
> loop and exit it
> when necessary eg: when icount elapse or cpu halted.

Yeah, I don't have a particularly strong opinion on that.  You can look
at my mttcg github branch for my rebase on top of yesterday's series.
It seems to work at least on the small GreenSoCs buildroot image.

Paolo