qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 00/12] qemu-common.h/osdep.h refactoring


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH 00/12] qemu-common.h/osdep.h refactoring
Date: Thu, 13 Aug 2015 18:37:46 +0100

On 22 July 2015 at 17:43, Peter Maydell <address@hidden> wrote:
> This series makes a start at cleaning up some of our headers
> to avoid the common problem of header files including qemu-common.h
> (which then in turn can lead to awkward circular includes).

The general consensus here seems to be that patches 1-9
are OK (and those have an R-by from Daniel), but that the
last three would be better dealt with by having osdep.h
be mandatory for .c files.

My suggestion is thus that we commit 1-9 now, which will
avoid them getting stale, and give us a sensible base for
mandating osdep.h inclusion everywhere.

I can just apply these directly to master, which seems the
easiest way to do it, unless anybody objects or would
particularly like to see them going through some other tree.

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]