qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH RFC 00/10] Enable repository wide style checking


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH RFC 00/10] Enable repository wide style checking
Date: Thu, 13 Aug 2015 18:53:36 +0100

On 31 July 2015 at 17:30, Daniel P. Berrange <address@hidden> wrote:
> Historically QEMU has relied on the checkpatch.pl script,
> borrowed from Linux, to check coding style compliance on
> patches which are submitted. For what it is designed for,
> it does a reasonable job, but I feel that QEMU would benefit
> from some more checking in this area, in particular checks
> that run across the entire repository, not just new patches.
>
> Rather than attempt to replace checkpatch.pl, this series
> illustrates how we can augment our existing style compliance
> checking. This imports the infrastructure from GNULIB which
> provides a 'syntax-check' target in the makefiles.

I like this in principle, but I notice that the GNULIB
infrastructure is GPLv3. I really would strongly prefer
that we not introduce any GPLv3 code into QEMU's git tree.
I don't want to get into trying to figure out whether
part of our makefile or build infrastructure being GPLv3
implies the generated binaries are GPLv3 or not; the simplest
approach is just to not allow any GPLv3 code into the git repo.

Is there no GPLv2 or GPLv2-or-later version of this code?

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]