qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH RFC 02/10] maint: remove double semicolons in ma


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH RFC 02/10] maint: remove double semicolons in many files
Date: Thu, 13 Aug 2015 18:57:55 +0100

On 31 July 2015 at 17:30, Daniel P. Berrange <address@hidden> wrote:
> A number of source files have statements accidentally
> terminated by a double semicolon - eg 'foo = bar;;'.
> This is harmless but a mistake none the less.
>
> The tcg/ia64/tcg-target.c file is whitelisted because
> it has valid use of ';;' in a comment containing assembly
> code.
>
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
>  block/vhdx.c         | 2 +-
>  cfg.mk               | 5 ++++-
>  hw/arm/vexpress.c    | 4 ++--
>  hw/intc/arm_gic.c    | 2 +-
>  numa.c               | 2 +-
>  qga/commands-win32.c | 2 +-
>  6 files changed, 10 insertions(+), 7 deletions(-)

If you kept the "enable the check in cfg.mk" change out of
the patches like these, we could review and commit them
without them being tangled up or waiting on the review of
the syntax-checking infrastructure itself...

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]