Re: [Qemu-devel] [PATCH RFC 02/10] maint: remove double semicolons in many files

[Daniel P. Berrange]

On Thu, Aug 13, 2015 at 06:57:55PM +0100, Peter Maydell wrote:
> On 31 July 2015 at 17:30, Daniel P. Berrange <address@hidden> wrote:
> > A number of source files have statements accidentally
> > terminated by a double semicolon - eg 'foo = bar;;'.
> > This is harmless but a mistake none the less.
> >
> > The tcg/ia64/tcg-target.c file is whitelisted because
> > it has valid use of ';;' in a comment containing assembly
> > code.
> >
> > Signed-off-by: Daniel P. Berrange <address@hidden>
> > ---
> >  block/vhdx.c         | 2 +-
> >  cfg.mk               | 5 ++++-
> >  hw/arm/vexpress.c    | 4 ++--
> >  hw/intc/arm_gic.c    | 2 +-
> >  numa.c               | 2 +-
> >  qga/commands-win32.c | 2 +-
> >  6 files changed, 10 insertions(+), 7 deletions(-)
> 
> If you kept the "enable the check in cfg.mk" change out of
> the patches like these, we could review and commit them
> without them being tangled up or waiting on the review of
> the syntax-checking infrastructure itself...

Sure, I just really wanted to illustrate the use of the syntax check
infrastructure with this series of fixes. Now I've done that I'll
resubmit just the fixes, while debate over the checking infrastructure
continues.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|