Re: [Qemu-devel] [PATCH 03/11] target-m68k: Remove incorrect clearing of cc_x

[Richard Henderson]

On Aug 14, 2015 10:04, Andreas Schwab <address@hidden> wrote:
>
> Richard Henderson <address@hidden> writes: 
>
> > The CF docs certainly doesnt suggest this is true. 
> > 
> > Signed-off-by: Richard Henderson <address@hidden> 
> > --- 
> >  target-m68k/helper.c | 7 ------- 
> >  1 file changed, 7 deletions(-) 
> > 
> > diff --git a/target-m68k/helper.c b/target-m68k/helper.c 
> > index c7b0fbe..6feb4bf 100644 
> > --- a/target-m68k/helper.c 
> > +++ b/target-m68k/helper.c 
> > @@ -205,19 +205,12 @@ static uint32_t cpu_m68k_flush_flags(CPUM68KState 
> > *env, int op) 
> >          break; 
> >      case CC_OP_LOGICB: 
> >          SET_NZ(dest, int8_t); 
> > -        goto set_x; 
> >          break; 
> >      case CC_OP_LOGICW: 
> >          SET_NZ(dest, int16_t); 
> > -        goto set_x; 
> >          break; 
> >      case CC_OP_LOGIC: 
> >          SET_NZ(dest, int32_t); 
> > -set_x: 
> > -        if (!m68k_feature(env, M68K_FEATURE_M68000)) { 
> > -            /* Unlike m68k, coldfire always clears the overflow bit.  */ 
>
> I think this refers to the muls/mulu insn, where the CF always clears V. 


Ah.  Except placed here it also applies to and/or/move too.

r~