Re: [Qemu-devel] [PATCH v2 5/6] Remove unused qemu_fls function

[Paolo Bonzini]

On 24/07/2015 14:33, Peter Maydell wrote:
> Nothing uses qemu_fls() any more, so delete it.
> 
> Signed-off-by: Peter Maydell <address@hidden>
> ---
>  include/qemu-common.h | 1 -
>  util/cutils.c         | 5 -----
>  2 files changed, 6 deletions(-)
> 
> diff --git a/include/qemu-common.h b/include/qemu-common.h
> index 237d654..bc6f8f8 100644
> --- a/include/qemu-common.h
> +++ b/include/qemu-common.h
> @@ -157,7 +157,6 @@ int stristart(const char *str, const char *val, const 
> char **ptr);
>  int qemu_strnlen(const char *s, int max_len);
>  char *qemu_strsep(char **input, const char *delim);
>  time_t mktimegm(struct tm *tm);
> -int qemu_fls(int i);
>  int qemu_fdatasync(int fd);
>  int fcntl_setfl(int fd, int flag);
>  int qemu_parse_fd(const char *param);
> diff --git a/util/cutils.c b/util/cutils.c
> index 5d1c9eb..43aafde 100644
> --- a/util/cutils.c
> +++ b/util/cutils.c
> @@ -145,11 +145,6 @@ time_t mktimegm(struct tm *tm)
>      return t;
>  }
>  
> -int qemu_fls(int i)
> -{
> -    return 32 - clz32(i);
> -}
> -
>  /*
>   * Make sure data goes on disk, but if possible do not bother to
>   * write out the inode just for timestamp updates.
> 

Reviewed-by: Paolo Bonzini <address@hidden>