[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.5 15/18] pc: Remove redundant arguments fr
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH for-2.5 15/18] pc: Remove redundant arguments from xen_hvm_init() |
Date: |
Mon, 17 Aug 2015 11:37:35 -0700 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Thu, Aug 13, 2015 at 02:06:04PM +0300, Michael S. Tsirkin wrote:
> On Fri, Aug 07, 2015 at 04:55:56PM -0300, Eduardo Habkost wrote:
[...]
> > @@ -1159,7 +1158,7 @@ static void xen_wakeup_notifier(Notifier *notifier,
> > void *data)
> > }
> >
> > /* return 0 means OK, or -1 means critical issue -- will exit(1) */
> > -int xen_hvm_init(ram_addr_t *below_4g_mem_size, ram_addr_t
> > *above_4g_mem_size,
> > +int xen_hvm_init(PCMachineState *pcms,
> > MemoryRegion **ram_memory)
> > {
> > int i, rc;
>
> This breaks the build: you didn't update the version in xen-hvm-stub.c
Oops, sorry.
>
> Please test on config with all options enabled.
I incorrectly assumed the changes wouldn't affect anything except PC, so
I was building it with --target-list=x86_64-softmmu --enable-xen. I
should remember to build it at least once with all targets enabled, next
time.
--
Eduardo
- [Qemu-devel] [PATCH for-2.5 07/18] pc: Eliminate pc_default_machine_options(), (continued)
- [Qemu-devel] [PATCH for-2.5 07/18] pc: Eliminate pc_default_machine_options(), Eduardo Habkost, 2015/08/07
- [Qemu-devel] [PATCH for-2.5 08/18] pc: Use PCMachineState for pc_cmos_init() argument, Eduardo Habkost, 2015/08/07
- [Qemu-devel] [PATCH for-2.5 09/18] pc: Use PCMachineState for pc_memory_init() argument, Eduardo Habkost, 2015/08/07
- [Qemu-devel] [PATCH for-2.5 10/18] pc: Move {above, below}_4g_mem_size variables to PCMachineState, Eduardo Habkost, 2015/08/07
- [Qemu-devel] [PATCH for-2.5 11/18] pc: Use PCMachineState as pc_guest_info_init() argument, Eduardo Habkost, 2015/08/07
- [Qemu-devel] [PATCH for-2.5 12/18] pc: Remove redundant arguments from *load_linux(), Eduardo Habkost, 2015/08/07
- [Qemu-devel] [PATCH for-2.5 13/18] pc: Remove redundant arguments from pc_cmos_init(), Eduardo Habkost, 2015/08/07
- [Qemu-devel] [PATCH for-2.5 14/18] pc: Remove redundant arguments from pc_memory_init(), Eduardo Habkost, 2015/08/07
- [Qemu-devel] [PATCH for-2.5 15/18] pc: Remove redundant arguments from xen_hvm_init(), Eduardo Habkost, 2015/08/07
- [Qemu-devel] [PATCH for-2.5 17/18] pc: Move legacy_acpi_table_size global to PCMachineClass, Eduardo Habkost, 2015/08/07
- [Qemu-devel] [PATCH for-2.5 16/18] pc: Move compat boolean globals to PCMachineClass, Eduardo Habkost, 2015/08/07
- [Qemu-devel] [PATCH for-2.5 18/18] pc: Move acpi_data_size global to PCMachineClass, Eduardo Habkost, 2015/08/07