[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] virtio-mmio: Kill code duplication
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] virtio-mmio: Kill code duplication |
Date: |
Wed, 19 Aug 2015 13:32:50 +0100 |
On 19 August 2015 at 12:23, Pavel Fedin <address@hidden> wrote:
> Extract common code for virtio-mmio creation and FDT node addition and
> put it into reusable functions. Use new functions in vexpress and virt
> machines.
>
> Signed-off-by: Pavel Fedin <address@hidden>
> ---
> hw/arm/sysbus-fdt.c | 51 +++++++++++++++++++++++++++++++
> hw/arm/vexpress.c | 55 ++++-----------------------------
> hw/arm/virt-acpi-build.c | 13 ++++----
> hw/arm/virt.c | 68
> +++++------------------------------------
> hw/virtio/virtio-mmio.c | 41 ++++++++++++++++++++++++-
> include/hw/arm/sysbus-fdt.h | 16 ++++++++++
> include/hw/virtio/virtio-mmio.h | 38 +++++++++++++++++++++++
> 7 files changed, 165 insertions(+), 117 deletions(-)
Why bother? This is adding more code than it deletes, and
is implicitly tying together details of how the these
two boards are laid out -- there's no inherent reason
that they have to be the same.
-- PMM