[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] virtio-mmio: Kill code duplication
|
From: |
Pavel Fedin |
|
Subject: |
Re: [Qemu-devel] [PATCH] virtio-mmio: Kill code duplication |
|
Date: |
Wed, 19 Aug 2015 15:45:34 +0300 |
Hello!
> Why bother? This is adding more code than it deletes
I just don't like code duplication, wanted to do this long time ago.
Additionally this enables to add support for virtio-mmio to more machines.
Actually it could be used not only by ARM with little modifications.
> and is implicitly tying together details of how the these
> two boards are laid out
What exactly do you mean? The only thing assumed by new functions is that
virtio-mmio devices are laid out in a single addresses window, one after
another. Base address and irq do not have to be the same everywhere.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia