Re: [Qemu-devel] [PATCH] hw/arm/virt-acpi-build: drop _ADR entry from SPCR

[Leif Lindholm]

On Thu, Aug 20, 2015 at 07:09:57PM +0800, Shannon Zhao wrote:
> >>>Could somebody who understands ACPI and the ramifications
> >>>here let me know if I should apply this patch, please?
> >>>(since we're now post-2.4)
> >>
> >>I presume my opinion is clear, but I'm cc:ing some of the Linaro ACPI
> >>team.
> >>
> >>Graeme, Al - the patch in question is:
> >>https://www.mail-archive.com/qemu-devel%40nongnu.org/msg314356.html
> >>
> >Using _ADR for a non enumerable bus is undefined behaviour in the ACPI
> >specification.
> >
> >How it is used in Redhats SPCR patch is IMO wrong becuase there is no
> >guarantee that _ADR will be defined for any MMIO device in DSDT.
> >
> >I believe QEMU should not follow this just to make a non upstreamed
> >Redhat patch work.
> >
> Yeah, but when will the right kernel patch be upstreamed? Do you
> have a plan for upstreaming it? Or it's on the list already?

It's on my way too long to-do list, but I'll need to send it out in
whatever state as an RFC this week anyway.

> As said before, we can apply this patch after the kernel patch upstreamed.

Meanwhile, it would be very bad if this becomes a de-facto standard,
using QEMU as a vector to (needlessly) change specifications through
the back door.

/
    Leif