qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Subject: [PATCH 01/16] linux-user: tilegx: Firstly add


From: Eric Blake
Subject: Re: [Qemu-devel] Subject: [PATCH 01/16] linux-user: tilegx: Firstly add architecture related features
Date: Thu, 20 Aug 2015 23:38:14 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0

On 08/20/2015 11:30 PM, Eric Blake wrote:
> On 08/20/2015 10:09 AM, gchen gchen wrote:
                          ^^^^^^^^^^^

> 
> In the subject line,
> s/Firstly add/Add/
> 
> ('Firstly' is seldom used in English, and certainly not in the context
> you were trying to use it)
> 
>> They are based on Linux kernel tilegx architecture for 64 bit binary,
>> and also based on tilegx ABI reference document, and also reference from
>> other targets implementations.
> 
> s/targets/targets'/
> 
>>
>> Signed-off-by: Chen Gang <address@hidden>
                  ^^^^^^^^^

Also, you may want to tweak your git settings so that your Author
designation matches your Signed-off-by designation.  It is okay to use
UTF-8 to represent your name natively, or even combine both native and
western representations, if you are comfortable with that.  It's a bit
more awkward to just use your login name (although it would not be the
first time that someone has committed to qemu using an alias rather than
a full name).

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]