[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] i386: keep cpu_model field in MachineState upto
|
From: |
Eduardo Habkost |
|
Subject: |
Re: [Qemu-devel] [PATCH] i386: keep cpu_model field in MachineState uptodate |
|
Date: |
Fri, 21 Aug 2015 09:21:37 -0700 |
|
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Fri, Aug 21, 2015 at 05:29:55PM +0800, Zhu Guihua wrote:
> Update cpu_model in MachineState for i386, so that the field can be used
> for cpu hotplug, instead of using a static variable.
>
> Signed-off-by: Zhu Guihua <address@hidden>
[...]
> -void pc_cpus_init(const char *cpu_model, DeviceState *icc_bridge)
> +void pc_cpus_init(DeviceState *icc_bridge)
> {
> int i;
> X86CPU *cpu = NULL;
> + MachineState *machine = MACHINE(qdev_get_machine());
All callers of pc_cpus_init() already have a PCMachineState object. If
you are already changing all pc_cpus_init() callers, please add a
PCMachineState object to pc_cpus_init() instead.
The rest of the patch looks good.
--
Eduardo