qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 6/7] [RFC] Use DEFINE_MACHINE to register all


From: Eduardo Habkost
Subject: Re: [Qemu-devel] [PATCH v2 6/7] [RFC] Use DEFINE_MACHINE to register all machines
Date: Fri, 21 Aug 2015 15:43:46 -0700
User-agent: Mutt/1.5.23 (2014-03-12)

On Wed, Aug 19, 2015 at 10:25:34AM +0200, Michael Walle wrote:
[...]
> >-static void lm32_machine_init(void)
> >+static void lm32_evr_machine_machine_init(MachineClass *mc)
> > {
> >-    qemu_register_machine(&lm32_uclinux_machine);
> >-    qemu_register_machine(&lm32_evr_machine);
> >+    mc->desc = "LatticeMico32 EVR32 eval system";
> >+    mc->init = lm32_evr_init;
> >+    mc->is_default = 1;
> > }
> >
> >-machine_init(lm32_machine_init);
> >+DEFINE_MACHINE("lm32-evr", lm32_evr_machine_machine_init);
> 
> lm32_evr_machine_machine_init, should be lm32_evr_machine_init. Maybe you
> can enable your script to detect "machine_machine" and just use one
> "machine" then. Same below.

Thanks. I will fix it in the next version.

-- 
Eduardo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]