[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 RESEND 03/11] netfilter: add netfilter_{add|d
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH v7 RESEND 03/11] netfilter: add netfilter_{add|del} commands |
Date: |
Sun, 23 Aug 2015 16:10:45 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 |
On 21/08/15 00:43, Yang Hongyang wrote:
> add netfilter_{add|del} commands
> This is mostly the same with netdev_{add|del} commands.
>
> When we delete the netdev, we also delete the netfilter object
> attached to it, because if the netdev is removed, the filters
> which attached to it is useless.
>
> Signed-off-by: Yang Hongyang <address@hidden>
> CC: Luiz Capitulino <address@hidden>
> CC: Markus Armbruster <address@hidden>
> CC: Eric Blake <address@hidden>
> ---
> v7: error msg fix
> move qmp_opts_del() into qemu_del_net_filter()
> v6: add multiqueue support (qemu_del_net_filter)
> v5: squash "net: delete netfilter object when delete netdev"
> ---
> hmp-commands.hx | 30 +++++++++++++++
> hmp.c | 29 +++++++++++++++
> hmp.h | 4 ++
> include/net/filter.h | 3 ++
> monitor.c | 33 +++++++++++++++++
> net/filter.c | 101
> ++++++++++++++++++++++++++++++++++++++++++++++++++-
> net/net.c | 7 ++++
> qapi-schema.json | 47 ++++++++++++++++++++++++
> qmp-commands.hx | 57 +++++++++++++++++++++++++++++
> 9 files changed, 310 insertions(+), 1 deletion(-)
Looks sane to me.
Reviewed-by: Thomas Huth <address@hidden>
- [Qemu-devel] [PATCH v7 RESEND 00/11] Add a netfilter object and netbuffer filter, Yang Hongyang, 2015/08/21
- [Qemu-devel] [PATCH v7 RESEND 01/11] net: add a new object netfilter, Yang Hongyang, 2015/08/21
- [Qemu-devel] [PATCH v7 RESEND 05/11] move out net queue structs define, Yang Hongyang, 2015/08/21
- [Qemu-devel] [PATCH v7 RESEND 02/11] init/cleanup of netfilter object, Yang Hongyang, 2015/08/21
- [Qemu-devel] [PATCH v7 RESEND 04/11] netfilter: hook packets before net queue send, Yang Hongyang, 2015/08/21
- [Qemu-devel] [PATCH v7 RESEND 06/11] netfilter: add an API to pass the packet to next filter, Yang Hongyang, 2015/08/21
- [Qemu-devel] [PATCH v7 RESEND 03/11] netfilter: add netfilter_{add|del} commands, Yang Hongyang, 2015/08/21
- Re: [Qemu-devel] [PATCH v7 RESEND 03/11] netfilter: add netfilter_{add|del} commands,
Thomas Huth <=
- [Qemu-devel] [PATCH v7 RESEND 10/11] filter/buffer: update command description and help, Yang Hongyang, 2015/08/21
- [Qemu-devel] [PATCH v7 RESEND 08/11] net/queue: export qemu_net_queue_append_iov, Yang Hongyang, 2015/08/21
- [Qemu-devel] [PATCH v7 RESEND 07/11] netfilter: print filter info associate with the netdev, Yang Hongyang, 2015/08/21
- [Qemu-devel] [PATCH v7 RESEND 09/11] netfilter: add a netbuffer filter, Yang Hongyang, 2015/08/21
- [Qemu-devel] [PATCH v7 RESEND 11/11] tests: add test cases for netfilter object, Yang Hongyang, 2015/08/21