[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC 25/38] cpu: add barriers around cpu->tcg_exit_req
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [RFC 25/38] cpu: add barriers around cpu->tcg_exit_req |
Date: |
Sun, 23 Aug 2015 19:01:20 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 |
On 23/08/2015 17:23, Emilio G. Cota wrote:
> @@ -16,6 +16,7 @@ static inline void gen_tb_start(TranslationBlock *tb)
>
> exitreq_label = gen_new_label();
> flag = tcg_temp_new_i32();
> + tcg_gen_smp_rmb();
> tcg_gen_ld_i32(flag, cpu_env,
> offsetof(CPUState, tcg_exit_req) - ENV_OFFSET);
> tcg_gen_brcondi_i32(TCG_COND_NE, flag, 0, exitreq_label);
This can also be done in cpu-exec.c. I have addressed Richard
Henderson's comments on the "signal-free TCG exit" patches and will
resend them asap.
Paolo
- Re: [Qemu-devel] [RFC 14/38] softmmu: add helpers to get ld/st physical addresses, (continued)
- [Qemu-devel] [RFC 29/38] tcg: export have_tb_lock, Emilio G. Cota, 2015/08/23
- [Qemu-devel] [RFC 25/38] cpu: add barriers around cpu->tcg_exit_req, Emilio G. Cota, 2015/08/23
- Re: [Qemu-devel] [RFC 25/38] cpu: add barriers around cpu->tcg_exit_req,
Paolo Bonzini <=
- [Qemu-devel] [RFC 23/38] cpu-exec: grab iothread lock during interrupt handling, Emilio G. Cota, 2015/08/23
- [Qemu-devel] [RFC 24/38] cpu-exec: reset mmap_lock after exiting the CPU loop, Emilio G. Cota, 2015/08/23
- [Qemu-devel] [RFC 09/38] rcu: fix comment with s/rcu_gp_lock/rcu_registry_lock/, Emilio G. Cota, 2015/08/23
- [Qemu-devel] [RFC 30/38] translate-all: add tb_lock assertions, Emilio G. Cota, 2015/08/23
- [Qemu-devel] [RFC 26/38] cpu: protect tb_jmp_cache with seqlock, Emilio G. Cota, 2015/08/23