Re: [Qemu-devel] [PATCH v4 1/3] linux-headers: Add eeh.h

[Gavin Shan]

On Mon, Aug 24, 2015 at 05:23:15PM +1000, Gavin Shan wrote:
>On Tue, Aug 11, 2015 at 10:11:03AM +0100, Peter Maydell wrote:
>>On 10 August 2015 at 08:13, Gavin Shan <address@hidden> wrote:
>>> The header file was introduced by following Linux upstream commits:
>>>
>>>     commit ed3e81f ("powerpc/eeh: Move PE state constants around")
>>>     commit ec33d36 ("powerpc/eeh: Introduce eeh_pe_inject_err()")
>>>
>>> Signed-off-by: Gavin Shan <address@hidden>
>>> ---
>>>  linux-headers/asm-powerpc/eeh.h | 56 
>>> +++++++++++++++++++++++++++++++++++++++++
>>>  1 file changed, 56 insertions(+)
>>>  create mode 100644 linux-headers/asm-powerpc/eeh.h
>>
>>Shouldn't this be added by updating scripts/update-linux-headers.sh
>>and then doing a plain "synchronize headers against kernel version $X" ?
>>Otherwise you won't get any future changes to this file.
>>
>
>When I started to sync header files with 4.2.0-rc2 kernel, I found lots
>of changes existing in the Linux kernel wasn't updated to QEMU source
>tree. Some changes were introduced into the kernel in 2013, for example
>commit 24bc69da ("PCI: Clean up MSI/MSI-X capability #defines"). Is there
>any reason why the header file wasn't updated in time?
>

Anyway, I'll sync all headers with 4.2.rc8 and change the source code
accordingly to use those macros valid in 4.2.rc8.

>Also, "struct virtio_pci_cfg_cap" has been removed from 4.2.0-rc2 kernel,
>but QEMU is still using it. If all header files are sync'ed with this
>kernel, then the source code should be adjusted as well. I'm not sure
>it's reasonable for someone who (like me) is unfamiliar with VFIO to do
>so? :-)

Please ignore this question. I was using wrong Linux git repository.
After switching to Linux upstream (mainline), I didn't find this issue.

Thanks,
Gavin