[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 2/7] crypto: introduce new module for TLS ano
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v4 2/7] crypto: introduce new module for TLS anonymous credentials |
Date: |
Mon, 24 Aug 2015 14:46:30 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 |
On 08/24/2015 08:14 AM, Daniel P. Berrange wrote:
> Introduce a QCryptoTLSCredsAnon class which is used to
> manage anonymous TLS credentials. Use of this class is
> generally discouraged since it does not offer strong
> security, but it is required for backwards compatibility
> with the current VNC server implementation.
>
> Simple example CLI configuration:
>
> $QEMU -object tls-creds-anon,id=tls0,endpoint=server
>
> Example using pre-created diffie-hellman parameters
>
> $QEMU -object tls-creds-anon,id=tls0,endpoint=server,\
> dir=/path/to/creds/dir
>
> The 'id' value in the -object args will be used to associate the
> credentials with the network services. For eample, when the VNC
s/eample/example/
> server is later converted it would use
>
> $QEMU -object tls-creds-anon,id=tls0,.... \
> -vnc 127.0.0.1:1,tls-creds=tls0
>
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
> +++ b/crypto/init.c
> @@ -20,6 +20,7 @@
>
> #include "crypto/init.h"
> #include "crypto/tlscreds.h"
> +#include "crypto/tlscredsanon.h"
> #include "qemu/thread.h"
>
> #ifdef CONFIG_GNUTLS
> @@ -144,6 +145,7 @@ int qcrypto_init(Error **errp)
> * clever enough to see the constructor :-(
> */
> qcrypto_tls_creds_dummy();
> + qcrypto_tls_creds_anon_dummy();
Are there any gcc hacks such as adding __attribute__((used)) that might
help?
> +++ b/crypto/tlscredsanon.c
> @@ -0,0 +1,235 @@
> +/* #define QCRYPTO_DEBUG */
> +
> +#ifdef QCRYPTO_DEBUG
> +#define DPRINTF(fmt, ...) do { fprintf(stderr, fmt, ## __VA_ARGS__); } while
> (0)
> +#else
> +#define DPRINTF(fmt, ...) do { } while (0)
> +#endif
Again, please rework this to avoid bitrot when debug is off (I'll quit
pointing it out, but suspect it to be a common problem in this series)
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v4 0/7] Extract TLS handling code from VNC server, Daniel P. Berrange, 2015/08/24
- [Qemu-devel] [PATCH v4 2/7] crypto: introduce new module for TLS anonymous credentials, Daniel P. Berrange, 2015/08/24
- Re: [Qemu-devel] [PATCH v4 2/7] crypto: introduce new module for TLS anonymous credentials,
Eric Blake <=
- [Qemu-devel] [PATCH v4 1/7] crypto: introduce new base module for TLS credentials, Daniel P. Berrange, 2015/08/24
- [Qemu-devel] [PATCH v4 3/7] crypto: introduce new module for TLS x509 credentials, Daniel P. Berrange, 2015/08/24
- [Qemu-devel] [PATCH v4 7/7] ui: convert VNC server to use QCryptoTLSSession, Daniel P. Berrange, 2015/08/24
- [Qemu-devel] [PATCH v4 6/7] ui: fix return type for VNC I/O functions to be ssize_t, Daniel P. Berrange, 2015/08/24
- [Qemu-devel] [PATCH v4 5/7] crypto: introduce new module for handling TLS sessions, Daniel P. Berrange, 2015/08/24
- [Qemu-devel] [PATCH v4 4/7] crypto: add sanity checking of TLS x509 credentials, Daniel P. Berrange, 2015/08/24