[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/6] virtio-pci: fix 1.0 virtqueue migration
From: |
Jason Wang |
Subject: |
Re: [Qemu-devel] [PATCH 3/6] virtio-pci: fix 1.0 virtqueue migration |
Date: |
Tue, 25 Aug 2015 11:14:05 +0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 |
On 08/24/2015 10:14 PM, Cornelia Huck wrote:
> On Mon, 24 Aug 2015 13:37:06 +0800
> Jason Wang <address@hidden> wrote:
>
>> On 08/21/2015 05:43 PM, Cornelia Huck wrote:
>>> On Fri, 21 Aug 2015 17:05:47 +0800
>>> Jason Wang <address@hidden> wrote:
>>>> + k->has_modern_state &&
>>>> + k->has_modern_state(qbus->parent);
>>>> +}
>>> I don't really like this "modern_state" stuff (which is pci specific)
>>> creeping into core.
>>>
>>> How about introducing "extra_state" and/or "extra_queue_state" (or
>>> something like that) instead?
>>>
>> Ok, if you don't like pci specific name, maybe something like
>> "virtio_1_state" is better?
> I was thinking more along the lines of "transport wants to save/restore
> additional state for the device" - which is not neccessarily depending
> on virtio-1. It would be good if a transport can extend the state
> without needlessly introducing incompatibilities.
I see.
>
> pci can handle its modern state via this then and encapsulate it.
>
Ok. Will have a try.
- [Qemu-devel] [PATCH 1/6] pc: introduce 2.5 machine type, (continued)
[Qemu-devel] [PATCH 4/6] virtio-pci: use wildcard mmio eventfd for 1.0 notification cap, Jason Wang, 2015/08/21
[Qemu-devel] [PATCH 5/6] virtio-pci: introduce pio notification capability for modern device, Jason Wang, 2015/08/21
[Qemu-devel] [PATCH 6/6] virtio-pci: unbreak queue_enable read, Jason Wang, 2015/08/21