Re: [Qemu-devel] [PATCH v6 3/8] scripts: Submit changes while updating linux headers

[Peter Maydell]

On 25 August 2015 at 00:58, Gavin Shan <address@hidden> wrote:
> On Mon, Aug 24, 2015 at 03:08:33PM +0100, Peter Maydell wrote:
>>On 24 August 2015 at 13:03, Gavin Shan <address@hidden> wrote:
>>> +    cd $to
>>> +    name=$(git config --get user.name)
>>> +    email=$(git config --get user.email)
>>> +    git commit -a -m "$subject" -m "$message" -m "Signed-off-by: $name 
>>> <$email>"
>>
>>Is git commit's --signoff option not present on all the git
>>versions we care about?

> We needn't care about if user.name and user.email are existing or not.
> If they're invalid, the commit log needs to be fixed manually. Or just
> to give explicit message like below to remind users to fix it? Anyway,
> the commit log isn't complete without correct name/email in SOB if
> I'm correct.
>
>     name=$(git config --get user.name)
>     email=$(git config --get user.email)
>     if ! [ "$name" ]; then
>         name="FIXME"
>     fi
>     if ! [ '$(echo "$email" | grep -v -e '@' > /dev/null)' ]; then
>         email="FIXME"
>     fi

My point is that you appear to be manually reimplementing
the built in git commit function for adding the SOB line,
and you haven't explained why you need to do that.

thanks
-- PMM