[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 07/18] nvdimm: reserve address range for NVDI
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v2 07/18] nvdimm: reserve address range for NVDIMM |
Date: |
Tue, 25 Aug 2015 16:12:47 +0100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Fri, Aug 14, 2015 at 10:52:00PM +0800, Xiao Guangrong wrote:
> diff --git a/hw/mem/nvdimm/pc-nvdimm.c b/hw/mem/nvdimm/pc-nvdimm.c
> index a53d235..7a270a8 100644
> --- a/hw/mem/nvdimm/pc-nvdimm.c
> +++ b/hw/mem/nvdimm/pc-nvdimm.c
> @@ -24,6 +24,19 @@
>
> #include "hw/mem/pc-nvdimm.h"
>
> +#define PAGE_SIZE (1UL << 12)
This macro name is likely to collide with system headers or other code.
Could you use the existing TARGET_PAGE_SIZE constant instead?
- [Qemu-devel] [PATCH v2 00/18] implement vNVDIMM, Xiao Guangrong, 2015/08/14
- [Qemu-devel] [PATCH v2 01/18] acpi: allow aml_operation_region() working on 64 bit offset, Xiao Guangrong, 2015/08/14
- [Qemu-devel] [PATCH v2 03/18] acpi: add aml_derefof, Xiao Guangrong, 2015/08/14
- [Qemu-devel] [PATCH v2 02/18] i386/acpi-build: allow SSDT to operate on 64 bit, Xiao Guangrong, 2015/08/14
- [Qemu-devel] [PATCH v2 04/18] acpi: add aml_sizeof, Xiao Guangrong, 2015/08/14
- [Qemu-devel] [PATCH v2 05/18] acpi: add aml_create_field, Xiao Guangrong, 2015/08/14
- [Qemu-devel] [PATCH v2 06/18] pc: implement NVDIMM device abstract, Xiao Guangrong, 2015/08/14
- [Qemu-devel] [PATCH v2 07/18] nvdimm: reserve address range for NVDIMM, Xiao Guangrong, 2015/08/14
- [Qemu-devel] [PATCH v2 08/18] nvdimm: init backend memory mapping and config data area, Xiao Guangrong, 2015/08/14