Re: [Qemu-devel] [PATCH 08/12] qga: move agent run in a seperate function

[Marc-André Lureau]

On Tue, Aug 25, 2015 at 6:51 PM, Michael Roth <address@hidden> wrote:
> It's hard to draw the line between what should be in main() as opposed
> to run_agent(), but we have some s->frozen initialization happening
> here, and then the statefile-based setting s->frozen values being set
> in run_agent(), so at least in this case we should move those back to
> main(). That means we probabably have to move the checks for the
> statefile existence/creation back to main() as well since s->frozen
> depends on it.

ok, I moved some frozen initialization in a check_is_frozen() function
called from main.

> I think that's the right place anyway, makes sense to load/init the
> persistent state file in the same location we handle the config file.


thanks

-- 
Marc-André Lureau