[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 5/9] tcg: assign cpu->current_tb in a simpler place
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PATCH 5/9] tcg: assign cpu->current_tb in a simpler place |
Date: |
Wed, 26 Aug 2015 02:17:41 +0200 |
TCG has not been reading cpu->current_tb from signal handlers for years.
The code that synchronized cpu_exec with the signal handler is not
needed anymore.
Signed-off-by: Paolo Bonzini <address@hidden>
---
cpu-exec.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/cpu-exec.c b/cpu-exec.c
index 2c3cb7d..7fcc46f 100644
--- a/cpu-exec.c
+++ b/cpu-exec.c
@@ -528,17 +528,13 @@ int cpu_exec(CPUState *cpu)
next_tb & TB_EXIT_MASK, tb);
}
tb_unlock();
- /* cpu_interrupt might be called while translating the
- TB, but before it is linked into a potentially
- infinite loop and becomes env->current_tb. Avoid
- starting execution if there is a pending interrupt. */
- cpu->current_tb = tb;
- barrier();
if (likely(!cpu->exit_request)) {
trace_exec_tb(tb, tb->pc);
tc_ptr = tb->tc_ptr;
/* execute the generated code */
+ cpu->current_tb = tb;
next_tb = cpu_tb_exec(cpu, tc_ptr);
+ cpu->current_tb = NULL;
switch (next_tb & TB_EXIT_MASK) {
case TB_EXIT_REQUESTED:
/* Something asked us to stop executing
@@ -581,7 +577,6 @@ int cpu_exec(CPUState *cpu)
break;
}
}
- cpu->current_tb = NULL;
/* Try to align the host and virtual clocks
if the guest is in advance */
align_clocks(&sc, cpu);
--
2.4.3
- [Qemu-devel] [PATCH v2 0/9] tcg: signal-free qemu_cpu_kick, Paolo Bonzini, 2015/08/25
- [Qemu-devel] [PATCH 3/9] tcg: introduce tcg_current_cpu, Paolo Bonzini, 2015/08/25
- [Qemu-devel] [PATCH 1/9] i8257: rewrite DMA_schedule to avoid hooking into the CPU loop, Paolo Bonzini, 2015/08/25
- [Qemu-devel] [PATCH 5/9] tcg: assign cpu->current_tb in a simpler place,
Paolo Bonzini <=
- [Qemu-devel] [PATCH 2/9] i8257: remove cpu_request_exit irq, Paolo Bonzini, 2015/08/25
- [Qemu-devel] [PATCH 6/9] tcg: synchronize cpu->exit_request and cpu->tcg_exit_req accesses, Paolo Bonzini, 2015/08/25
- [Qemu-devel] [PATCH 4/9] remove qemu/tls.h, Paolo Bonzini, 2015/08/25
- [Qemu-devel] [PATCH 7/9] tcg: synchronize exit_request and tcg_current_cpu accesses, Paolo Bonzini, 2015/08/25
- [Qemu-devel] [PATCH 8/9] use qemu_cpu_kick instead of cpu_exit or qemu_cpu_kick_thread, Paolo Bonzini, 2015/08/25
- [Qemu-devel] [PATCH 9/9] tcg: signal-free qemu_cpu_kick, Paolo Bonzini, 2015/08/25
- Re: [Qemu-devel] [PATCH v2 0/9] tcg: signal-free qemu_cpu_kick, Richard Henderson, 2015/08/28