[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 10/12] qga: add an optionnal qemu-ga.conf sys
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v2 10/12] qga: add an optionnal qemu-ga.conf system configuration |
Date: |
Wed, 26 Aug 2015 10:01:50 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
address@hidden writes:
> From: Marc-André Lureau <address@hidden>
>
> Learn to configure the agent with a system configuration.
>
> This may simplify command-line handling, especially when the blacklist
> is long.
>
> Among the other benefits, this may standardize the configuration of a
> init service (instead of distro-specific init keys/files)
>
> Signed-off-by: Marc-André Lureau <address@hidden>
This uses GLib's Key-value file parser. Note that we have our own .ini
parser qemu_config_parse(). It predates our use of GLib. Having two
different parsers risks inconsistency. Since qga is already using
GLib's, using it some more there is better than adding a use of our own
parser, so no objection to your patch on that ground.
Replacing qemu_config_parse()'s parsing guts by GLib probably won't save
code, but it could be nice for consistency. Well outside this patch's
scope, of course.