Re: [Qemu-devel] [PATCH RFC 0/5] Network traffic dumping via netfilter

[Jason Wang]

On 08/27/2015 10:33 AM, Thomas Huth wrote:
> The "-net dump" option only works with the "-net" option. So far, it
> is not possible to dump network traffic with the "-netdev" option yet.
> This patch series now fixes this ugliness by enabling dumping for the
> netdev devices via the new netfilter infrastructure. It can be used
> like this for example:
>
>  qemu-system-ppc64 -nographic -vga none -device virtio-net,netdev=mynet \
>    -netdev user,id=mynet,tftp=/tmp/tftp,bootfile=zImage -boot n \
>    -netfilter dump,id=f0,netdev=mynet,file=/tmp/filterdump.dat
>
> This series is based on v8 of Yang Hongyang's netfilter patches
> (i.e. these have to be applied before the dumping patches can be
> used). Since these netfilter patches are not upstream yet and still
> might change the API in future versions, I'm sending my patches as
> "RFC" (but since the integration with the current netfilter patches
> was pretty easy already, they should be ready as normal patches very
> soon after the netfilter patches have been finalized).
>
> Thomas Huth (5):
>   net/dump: Add support for receive_iov function
>   net/dump: Rework net-dump init functions
>   net/dump: Separate the NetClientState from the DumpState
>   net/dump: Provide the dumping facility as a net filter
>   net/dump: Add documentation
>
>  net/dump.c       | 152 
> ++++++++++++++++++++++++++++++++++++++++++++-----------
>  net/filter.c     |   1 +
>  net/filters.h    |   2 +
>  qapi-schema.json |  20 +++++++-
>  qemu-options.hx  |  15 ++++--
>  5 files changed, 155 insertions(+), 35 deletions(-)
>

Looks good to me.

Thanks