qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 3/4] build: qemu-ga: fix VSS dependencies


From: Michael Roth
Subject: Re: [Qemu-devel] [PATCH 3/4] build: qemu-ga: fix VSS dependencies
Date: Thu, 27 Aug 2015 08:46:43 -0500
User-agent: alot/0.3.6

Quoting Marc-André Lureau (2015-08-27 07:49:19)
> Hi
> 
> On Thu, Aug 27, 2015 at 12:21 AM, Michael Roth
> <address@hidden> wrote:
> > +qemu-ga$(EXESUF): $(qga-obj-y) libqemuutil.a libqemustub.a 
> > $(QGA_VSS_PROVIDER)
> > +       $(call LINK, $(filter-out %.tlb %.dll, $^))
> 
> Strictly this is not so great, but that makes sense: so perhaps a
> small comment above to explain it would be good.

Will add a comment either way, but perhaps something like:

qemu-ga$(EXESUF): $(qga-obj-y) libqemuutil.a libqemustub.a $(QGA_VSS_PROVIDER)
       $(call LINK, $(filter-out $(QGA_VSS_PROVIDER), $^))

would be clearer? I suppose it's a bit more future-proof as well, if we added
more dependencies to QGA_VSS_PROVIDER for some reason.

> 
> Reviewed-by: Marc-André Lureau <address@hidden>
> 
> 
> 
> -- 
> Marc-André Lureau
> 




reply via email to

[Prev in Thread] Current Thread [Next in Thread]