qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4 04/13] qga: make split_list() return allocate


From: Denis V. Lunev
Subject: Re: [Qemu-devel] [PATCH v4 04/13] qga: make split_list() return allocated strings
Date: Thu, 27 Aug 2015 19:15:04 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0

On 08/27/2015 05:30 PM, Marc-André Lureau wrote:
Hi

On Thu, Aug 27, 2015 at 11:17 AM, Denis V. Lunev <address@hidden> wrote:
why not to
__str = g_strsplit(str, delim, -1);
+    strv = g_strsplit(str, delim, -1);
+    for (i = 0; strv[i]; i++) {
+        list = g_list_prepend(list, strv[i]);
       }
+    g_free(strv);
g_free(__str);

This will remove all burden from callers.
You will be able to use const char * as argument too.

Sorry, I don't understand, could you propose a different patch?

you are right, me wrong :) I have mis-read the code.
This one is perfect.

Reviewed-by: Denis V. Lunev <address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]