Re: [Qemu-devel] [PATCH v4 00/13] qemu-ga: add a configuration file

[Denis V. Lunev]

On 08/27/2015 02:34 AM, address@hidden wrote:
> From: Marc-André Lureau <address@hidden>
>
> Hi,
>
> The following patches for the qemu agent add support for an optionnal
> configuration file, and a man page.
>
> v3->v4:
> - some spelling fixes
> - add a patch to allocate in split_list()
> - add more details in "copy argument strings" patch
> - add some g_free() in config_parse()
> - add an assert() after g_key_file_new()
> v2->v3:
> - fix compilation in intermediate patch
> - remove some extra space in intermediate patch
> - add some missing Reviewed-by tags
> v1->v2:
> - spelling fixes
> - change device_path to channel_path
> - moving config to GAConfig struct
> - do check_is_frozen() during main
> - use g_key_file_to_data() for the dump
>
> This is related to this RFE:
> https://bugzilla.redhat.com/show_bug.cgi?id=1101556
>
> Marc-André Lureau (13):
>    qga: misc spelling
>    qga: use exit() when parsing options
>    qga: move string split in separate function
>    qga: make split_list() return allocated strings
>    qga: rename 'path' to 'channel_path'
>    qga: copy argument strings
>    qga: move option parsing to separate function
>    qga: fill default options in main()
>    qga: move agent run in a separate function
>    qga: free a bit more
>    qga: add an optional qemu-ga.conf system configuration
>    qga: add --dump-conf option
>    qga: start a man page
>
>   Makefile             |  14 +-
>   qemu-doc.texi        |   6 +
>   qemu-ga.texi         | 136 +++++++++++++++
>   qga/commands-posix.c |   6 +-
>   qga/commands-win32.c |   4 +-
>   qga/main.c           | 468 ++++++++++++++++++++++++++++++++++++---------------
>   qga/qapi-schema.json |   2 +-
>   7 files changed, 490 insertions(+), 146 deletions(-)
>   create mode 100644 qemu-ga.texi
There are 2 really small notes which are quite minor.
Thus for entire stuff except man page, which I am
not a right person to review, but you can add my
R-b at your taste.

Reviewed-by: Denis V. Lunev <address@hidden>