Re: [Qemu-devel] [PATCH] s390: fix softmmu compilation

[Laurent Vivier]

Le 28/08/2015 12:08, Peter Maydell a écrit :
> On 28 August 2015 at 11:03, Peter Maydell <address@hidden> wrote:
>> On 28 August 2015 at 10:15, Cornelia Huck <address@hidden> wrote:
>>> On Fri, 28 Aug 2015 11:09:05 +0200
>>> Laurent Vivier <address@hidden> wrote:
>>>
>>>> guest_base must be used only in linux-user mode.
>>>>
>>>> Signed-off-by: Laurent Vivier <address@hidden>
>>>> ---
>>>>  tcg/s390/tcg-target.c | 2 ++
>>>>  1 file changed, 2 insertions(+)
>>>>
>>>
>>> Thanks, that fixed compilation on s390 for me.
>>
>> I'm planning to apply this directly to master as a buildfix.
> 
> Incidentally, minor cleanup now possible: TCG_GUEST_BASE_REG
> is now only used inside ifndef CONFIG_SOFTMMU, so you can drop
> the #define of it to TCG_REG_R0 in the softmmu case.

You're right I send a v2...

Laurent