qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 07/10] tcg: comment on which functions have to b


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH 07/10] tcg: comment on which functions have to be called with mmap_lock held
Date: Fri, 28 Aug 2015 16:33:09 +0100

On 12 August 2015 at 17:40, Paolo Bonzini <address@hidden> wrote:
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
>  translate-all.c | 29 ++++++++++++++++++++++-------
>  1 file changed, 22 insertions(+), 7 deletions(-)

Some overall documentation on what the mmap_lock is protecting
(and thus when it needs to be taken) would be nice.

Otherwise
Reviewed-by: Peter Maydell <address@hidden>

I couldn't see where we take the mmap_lock when we call
tb_gen_code() from tb_find_slow() -- how does that work?

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]