[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 09/10] exec: make mmap_lock/mmap_unlock globally
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 09/10] exec: make mmap_lock/mmap_unlock globally available |
Date: |
Fri, 28 Aug 2015 16:42:15 +0100 |
On 12 August 2015 at 17:41, Paolo Bonzini <address@hidden> wrote:
> There is some iffy lock hierarchy going on in translate-all.c. To
> fix it, we need to take the mmap_lock in cpu-exec.c. Make the
> functions globally available.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> bsd-user/qemu.h | 2 --
> include/exec/exec-all.h | 7 ++++++-
> linux-user/qemu.h | 2 --
> translate-all.c | 5 -----
> 4 files changed, 6 insertions(+), 10 deletions(-)
>
> diff --git a/bsd-user/qemu.h b/bsd-user/qemu.h
> index 5362297..5902614 100644
> --- a/bsd-user/qemu.h
> +++ b/bsd-user/qemu.h
> @@ -213,8 +213,6 @@ abi_long target_mremap(abi_ulong old_addr, abi_ulong
> old_size,
> abi_ulong new_addr);
> int target_msync(abi_ulong start, abi_ulong len, int flags);
> extern unsigned long last_brk;
> -void mmap_lock(void);
> -void mmap_unlock(void);
> void cpu_list_lock(void);
> void cpu_list_unlock(void);
> #if defined(CONFIG_USE_NPTL)
> diff --git a/include/exec/exec-all.h b/include/exec/exec-all.h
> index eb77373..b3f900a 100644
> --- a/include/exec/exec-all.h
> +++ b/include/exec/exec-all.h
> @@ -318,7 +318,6 @@ extern uintptr_t tci_tb_ptr;
> #define GETPC() (GETRA() - GETPC_ADJ)
>
> #if !defined(CONFIG_USER_ONLY)
> -
> struct MemoryRegion *iotlb_to_region(CPUState *cpu,
> hwaddr index);
>
Stray whitespace change.
Otherwise
Reviewed-by: Peter Maydell <address@hidden>
thanks
-- PMM
- [Qemu-devel] [PATCH 08/10] tcg: add memory barriers in page_find_alloc accesses, (continued)
- [Qemu-devel] [PATCH 04/10] exec-all: remove non-TCG stuff from exec-all.h header., Paolo Bonzini, 2015/08/12
- [Qemu-devel] [PATCH 06/10] tcg: code_bitmap is not used by user-mode emulation, Paolo Bonzini, 2015/08/12
- [Qemu-devel] [PATCH 09/10] exec: make mmap_lock/mmap_unlock globally available, Paolo Bonzini, 2015/08/12
- Re: [Qemu-devel] [PATCH 09/10] exec: make mmap_lock/mmap_unlock globally available,
Peter Maydell <=
- [Qemu-devel] [PATCH 11/10] tcg: comment on which functions have to be called with tb_lock held, Paolo Bonzini, 2015/08/12
- Re: [Qemu-devel] [PATCH 11/10] tcg: comment on which functions have to be called with tb_lock held, Frederic Konrad, 2015/08/13
- Re: [Qemu-devel] [PATCH 11/10] tcg: comment on which functions have to be called with tb_lock held, Paolo Bonzini, 2015/08/13
- Re: [Qemu-devel] [PATCH 11/10] tcg: comment on which functions have to be called with tb_lock held, Frederic Konrad, 2015/08/13
- Re: [Qemu-devel] [PATCH 11/10] tcg: comment on which functions have to be called with tb_lock held, Paolo Bonzini, 2015/08/13
- Re: [Qemu-devel] [PATCH 11/10] tcg: comment on which functions have to be called with tb_lock held, Peter Maydell, 2015/08/13
- Re: [Qemu-devel] [PATCH 11/10] tcg: comment on which functions have to be called with tb_lock held, Paolo Bonzini, 2015/08/13
[Qemu-devel] [PATCH 10/10] cpu-exec: fix lock hierarchy for user-mode emulation, Paolo Bonzini, 2015/08/12
[Qemu-devel] [PATCH 12/10] tcg: protect TBContext with tb_lock., Paolo Bonzini, 2015/08/12