[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 8/9] ui: fix return type for VNC I/O function
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v5 8/9] ui: fix return type for VNC I/O functions to be ssize_t |
Date: |
Fri, 28 Aug 2015 15:08:41 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 |
On 08/26/2015 09:05 AM, Daniel P. Berrange wrote:
> Various VNC server I/O functions return 'long' and then
> also pass this to a method accepting 'int'. All these
> should be ssize_t to match the signature of read/write
> APIs and thus avoid potential for integer truncation /
> wraparound.
>
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
> ui/vnc.c | 36 ++++++++++++++++++------------------
> ui/vnc.h | 6 +++---
> 2 files changed, 21 insertions(+), 21 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v5 2/9] make: ensure all members of libqemuutil.a are linked, (continued)
- [Qemu-devel] [PATCH v5 3/9] crypto: introduce new base module for TLS credentials, Daniel P. Berrange, 2015/08/26
- [Qemu-devel] [PATCH v5 1/9] qapi: allow override of default enum prefix naming, Daniel P. Berrange, 2015/08/26
- [Qemu-devel] [PATCH v5 5/9] crypto: introduce new module for TLS x509 credentials, Daniel P. Berrange, 2015/08/26
- [Qemu-devel] [PATCH v5 8/9] ui: fix return type for VNC I/O functions to be ssize_t, Daniel P. Berrange, 2015/08/26
- Re: [Qemu-devel] [PATCH v5 8/9] ui: fix return type for VNC I/O functions to be ssize_t,
Eric Blake <=
- [Qemu-devel] [PATCH v5 4/9] crypto: introduce new module for TLS anonymous credentials, Daniel P. Berrange, 2015/08/26
- [Qemu-devel] [PATCH v5 7/9] crypto: introduce new module for handling TLS sessions, Daniel P. Berrange, 2015/08/26
- [Qemu-devel] [PATCH v5 9/9] ui: convert VNC server to use QCryptoTLSSession, Daniel P. Berrange, 2015/08/26
- [Qemu-devel] [PATCH v5 6/9] crypto: add sanity checking of TLS x509 credentials, Daniel P. Berrange, 2015/08/26