qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v5 8/9] ui: fix return type for VNC I/O function


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v5 8/9] ui: fix return type for VNC I/O functions to be ssize_t
Date: Fri, 28 Aug 2015 15:08:41 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0

On 08/26/2015 09:05 AM, Daniel P. Berrange wrote:
> Various VNC server I/O functions return 'long' and then
> also pass this to a method accepting 'int'. All these
> should be ssize_t to match the signature of read/write
> APIs and thus avoid potential for integer truncation /
> wraparound.
> 
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
>  ui/vnc.c | 36 ++++++++++++++++++------------------
>  ui/vnc.h |  6 +++---
>  2 files changed, 21 insertions(+), 21 deletions(-)
> 

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]