[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [snabb-devel] Re: [PATCH v6 1/2] vhost-user: add multi
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [snabb-devel] Re: [PATCH v6 1/2] vhost-user: add multi queue support |
Date: |
Mon, 31 Aug 2015 09:04:25 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 |
On 08/31/2015 05:30 AM, Michael S. Tsirkin wrote:
> On Mon, Aug 31, 2015 at 08:29:39AM +0000, Ouyang, Changchun wrote:
>>>>>>> On Wed, Aug 12, 2015 at 02:25:41PM +0800, Ouyang Changchun wrote:
>>>>>>>> Based on patch by Nikolay Nikolaev:
When you start to have this much nested quoting,...
>>>>>>>> -269,7 +270,7 @@ static void vhost_net_stop_one(struct
>>>>>>>> vhost_net
>>>>> *net,
>>>>>>>> for (file.index = 0; file.index < net->dev.nvqs;
>>>>>>>> ++file.index) {
>>>>>>>> const VhostOps *vhost_ops = net->dev.vhost_ops;
>>>>>>>> int r = vhost_ops->vhost_call(&net->dev,
>>> VHOST_RESET_OWNER,
...line wrapping of the quotes gets funky and starts mis-attributing
portions of lines to the wrong quote level.
>> Vhost backend can't support the queues number as much as the guest/qemu
>> requires,
>> I think you mean we should let qemu exit in such a case, right?
>
> Exactly.
And mis-attribution makes it that much harder to find the real content
being added further down in the middle of 28k of mostly-quoted message.
Please remember that it is okay to trim messages to the relevant
portions, to make it easier for readers to quickly get at the new content.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v6 1/2] vhost-user: add multi queue support, (continued)
- [Qemu-devel] [PATCH v6 1/2] vhost-user: add multi queue support, Ouyang Changchun, 2015/08/12
- Re: [Qemu-devel] [PATCH v6 1/2] vhost-user: add multi queue support, Michael S. Tsirkin, 2015/08/13
- Re: [Qemu-devel] [snabb-devel] Re: [PATCH v6 1/2] vhost-user: add multi queue support, Ouyang, Changchun, 2015/08/24
- Re: [Qemu-devel] [snabb-devel] Re: [PATCH v6 1/2] vhost-user: add multi queue support, Michael S. Tsirkin, 2015/08/27
- Re: [Qemu-devel] [snabb-devel] Re: [PATCH v6 1/2] vhost-user: add multi queue support, Ouyang, Changchun, 2015/08/27
- Re: [Qemu-devel] [snabb-devel] Re: [PATCH v6 1/2] vhost-user: add multi queue support, Michael S. Tsirkin, 2015/08/30
- Re: [Qemu-devel] [snabb-devel] Re: [PATCH v6 1/2] vhost-user: add multi queue support, Ouyang, Changchun, 2015/08/31
- Re: [Qemu-devel] [snabb-devel] Re: [PATCH v6 1/2] vhost-user: add multi queue support, Michael S. Tsirkin, 2015/08/31
- Re: [Qemu-devel] [snabb-devel] Re: [PATCH v6 1/2] vhost-user: add multi queue support,
Eric Blake <=
[Qemu-devel] [PATCH v6 2/2] vhost-user: new protocol feature for multi queue, Ouyang Changchun, 2015/08/12