qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 27/31] qapi: Drop one of two "simple union must


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH 27/31] qapi: Drop one of two "simple union must not have base" checks
Date: Mon, 31 Aug 2015 10:05:54 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0

On 08/31/2015 09:55 AM, Markus Armbruster wrote:
> The first check ensures the second one can't trigger.  Drop the first
> one, because the second one is in a more logical place, and emits a
> nicer error message.

Second one added in 44bd1276; first one in older a8d4a2e4 (back before
'alternate' existed).  I probably failed to delete the first one due to
rebase churn on my end.

> 
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  scripts/qapi.py                                   | 8 --------
>  tests/qapi-schema/union-base-no-discriminator.err | 2 +-
>  2 files changed, 1 insertion(+), 9 deletions(-)

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]