Re: [Qemu-devel] [PATCH v14 26/33] target-tilegx: Handle scalar multiply instructions

[Richard Henderson]

On 08/30/2015 06:46 AM, Peter Maydell wrote:
> On 24 August 2015 at 17:17, Richard Henderson <address@hidden> wrote:
> > Signed-off-by: Richard Henderson <address@hidden>
> > ---
> >   target-tilegx/translate.c | 112 ++++++++++++++++++++++++++++++++++++++++++++++
> >   1 file changed, 112 insertions(+)
>
> It seems a shame that these are all 32x32->64 multiplies
> (or in some cases 32x32->32), but we won't actually be able
> to make use of a host CPU 32x32->64 instruction.

Indeed.  For the most part I've been assuming a 64-bit host for all the ports 
I've been working on recently.  At which point it's not really worth doing all 
of the truncation and extension required to use such insns.


r~

> Still, these give the right results I think so
> Reviewed-by: Peter Maydell <address@hidden>
>
> thanks
> -- PMM