Re: [Qemu-devel] [PATCH v14 29/33] target-tilegx: Handle mtspr, mfspr

[Richard Henderson]

On 08/30/2015 08:18 AM, Peter Maydell wrote:
> > +static const TileSPR *find_spr(unsigned spr)
> > +{
> > +    /* Allow the compiler to construct the binary search tree.  */
>
> This feels a bit overly clever to me but if we only have
> three registers anyway it doesn't matter much.

I was just forward looking to system mode.  There's a *lot* of sprs defined in 
spr_def_64.h.

> > +    D(SIM_CONTROL,
> > +      offsetof(CPUTLGState, spregs[TILEGX_SPR_CRITICAL_SEC]), 0, 0)
> > +    D(INTERRUPT_CRITICAL_SECTION,
> > +      offsetof(CPUTLGState, spregs[TILEGX_SPR_SIM_CONTROL]), 0, 0)
>
> Aren't the offsets on these two backwards ?

Fixed, thanks.


r~