qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4 13/13] qga: start a man page


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v4 13/13] qga: start a man page
Date: Tue, 1 Sep 2015 09:11:28 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0

On 08/31/2015 05:28 PM, Michael Roth wrote:

>> Overall, fairly clean.
> 
> Thanks for the review. Since these are grammatical fixes I've gone ahead and
> squashed these changes in, the only exception being suggestions regarding
> 'path' (the POSIX interpretation seems to make much more sense than 
> associating
> it with an unrelated environment variable's semantics), and the ones that are
> outside the scope of this patch (short option args and 'help' as an 
> alternative
> to '?').
> 
> https://github.com/mdroth/qemu/commit/0e58c84d8618532bf6c3dcd3d13139fed5aaf3ca
> 
> Sending a pull later this week, can add your Reviewed-by if it looks okay.

I've looked that over, and I'm okay if you want to amend and add:
Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]