Re: [Qemu-devel] [PATCH v3 5/8] s390x: Dump-skeys hmp support

[Cornelia Huck]

On Tue, 1 Sep 2015 10:05:17 -0600
Eric Blake <address@hidden> wrote:

> On 09/01/2015 08:30 AM, Cornelia Huck wrote:
> 
> >>>> +++ b/hmp-commands.hx
> >>>> @@ -1053,6 +1053,22 @@ gdb. Without -z|-l|-s, the dump format is ELF.
> >>>>               together with begin.
> >>>>   ETEXI
> >>>>
> >>>> +#if defined(TARGET_S390X)
> >>>> +    {
> >>>> +        .name       = "dump-skeys",
> >>>
> >>> Most HMP commands use '_', not '-', for word separation.
> >>>
> >>
> >> I patterned my new command after dump-guest-memory since the functionality
> >> was similar. Though it is easy enough to change if you would like.
> > 
> > Eric, do you have a strong preference? I think either is fine; I can
> > either keep it as-is or merge in a change for the pull.
> 
> HMP is not ABI; we can change it at will without worrying about
> back-compat issues.  Consistency is nice, so I'd lean towards
> consistently using _ throughout HMP, but the preference is not strong
> enough so I don't object to keeping this commit as-is for the sake of
> merging, especially if dump-guest-memory also needs changing (that is, a
> followup patch that changes all HMP to be consistent in one go is not
> that much harder, even if this patch adds to the workload of that patch).

Given that there are even more commands using - and that we can change
this later on, I'll just leave it as-is.