[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 2/2] rtl8139: Do not consume the packet durin
From: |
Jason Wang |
Subject: |
Re: [Qemu-devel] [PATCH v4 2/2] rtl8139: Do not consume the packet during overflow in standard mode. |
Date: |
Wed, 2 Sep 2015 11:09:40 +0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
On 09/01/2015 11:26 PM, Vladislav Yasevich wrote:
> When operation in standard mode, we currently return the size
> of packet during buffer overflow. This consumes the overflow
> packet. Return 0 instead so we can re-process the overflow packet
> when we have room.
>
> This fixes issues with lost/dropped fragments of large messages.
>
> Signed-off-by: Vladislav Yasevich <address@hidden>
> ---
> hw/net/rtl8139.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/net/rtl8139.c b/hw/net/rtl8139.c
> index 8a33466..cb51613 100644
> --- a/hw/net/rtl8139.c
> +++ b/hw/net/rtl8139.c
> @@ -1159,7 +1159,7 @@ static ssize_t rtl8139_do_receive(NetClientState *nc,
> const uint8_t *buf, size_t
> s->IntrStatus |= RxOverflow;
> ++s->RxMissed;
> rtl8139_update_irq(s);
> - return size_;
> + return 0;
> }
>
> packet_header |= RxStatusOK;
Reviewed-by: Jason Wang <address@hidden>