[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 1/2] virtio dataplane: adapt dataplane for vi
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH v3 1/2] virtio dataplane: adapt dataplane for virtio Version 1 |
|
Date: |
Wed, 2 Sep 2015 09:59:37 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 |
[meta-comment]
On 09/02/2015 09:12 AM, Pierre Morel wrote:
> Let dataplane allocate different region for the desc/avail/used
> ring regions.
> Take VIRTIO_RING_F_EVENT_IDX into account to increase the used/avail
> rings accordingly.
This part is fine.
>
> Changes from V2:
> - incorporate the code directly in vring_setup().
> - added room for the event indexes used with VIRTIO_RING_F_EVENT_IDX
>
> Changes from v1:
> - use a macro to gain LOCs inside of vring_setup()
But the above changelog text belongs better...
>
> Signed-off-by: Pierre Morel <address@hidden>
> ---
...here after the '---' separator, where it will be stripped by 'git
am'. It is useful for reviewers of the earlier versions, but in the
long run, when reading 'git log', we will only care about what got
committed, not how many tries it took to get to that point.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature