[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 15/16] support replication driver in blockdev-ad
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 15/16] support replication driver in blockdev-add |
Date: |
Wed, 2 Sep 2015 10:36:41 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 |
On 09/02/2015 02:51 AM, Wen Congyang wrote:
> Signed-off-by: Wen Congyang <address@hidden>
> ---
> qapi/block-core.json | 18 ++++++++++++++++--
> 1 file changed, 16 insertions(+), 2 deletions(-)
>
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index 96f0530..86275e3 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -1383,7 +1383,7 @@
> 'dmg', 'file', 'ftp', 'ftps', 'host_cdrom', 'host_device',
> 'host_floppy', 'http', 'https', 'null-aio', 'null-co',
> 'parallels',
> 'qcow', 'qcow2', 'qed', 'quorum', 'raw', 'tftp', 'vdi', 'vhdx',
> - 'vmdk', 'vpc', 'vvfat', 'nbd' ] }
> + 'vmdk', 'vpc', 'vvfat', 'nbd', 'replication' ] }
'nbd' is not in the current qemu.git; which means your patch series
depends on a prerequisite series. Please mention that sort of
information in your cover letter.
Please keep this enum in alphabetical order.
Missing documentation under @drv of BlockDeviceInfo that this was
introduced in 2.5.
>
> ##
> # @BlockdevOptionsBase
> @@ -1825,6 +1825,19 @@
> { 'enum' : 'ReplicationMode', 'data' : [ 'primary', 'secondary' ] }
>
> ##
> +# @BlockdevOptionsReplication
> +#
> +# Driver specific block device options for replication
> +#
> +# @mode: the replication mode
Can the mode be 'unprotected', or must it be 'primary' or 'secondary'
when first creating a replication BDS?
> +#
> +# Since: 2.5
> +##
> +{ 'struct': 'BlockdevOptionsReplication',
> + 'base': 'BlockdevOptionsGenericFormat',
> + 'data': { 'mode': 'ReplicationMode' } }
> +
> +##
> # @BlockdevOptions
> #
> # Options for creating a block device.
> @@ -1869,7 +1882,8 @@
> 'vhdx': 'BlockdevOptionsGenericFormat',
> 'vmdk': 'BlockdevOptionsGenericCOWFormat',
> 'vpc': 'BlockdevOptionsGenericFormat',
> - 'vvfat': 'BlockdevOptionsVVFAT'
> + 'vvfat': 'BlockdevOptionsVVFAT',
> + 'replication':'BlockdevOptionsReplication'
> } }
It helps to keep this alphabetical.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 11/16] Add new block driver interfaces to control block replication, (continued)
- [Qemu-devel] [PATCH 11/16] Add new block driver interfaces to control block replication, Wen Congyang, 2015/09/02
- [Qemu-devel] [PATCH 12/16] skip nbd_target when starting block replication, Wen Congyang, 2015/09/02
- [Qemu-devel] [PATCH 13/16] quorum: implement block driver interfaces for block replication, Wen Congyang, 2015/09/02
- [Qemu-devel] [PATCH 10/16] docs: block replication's description, Wen Congyang, 2015/09/02
- [Qemu-devel] [PATCH 15/16] support replication driver in blockdev-add, Wen Congyang, 2015/09/02
- Re: [Qemu-devel] [PATCH 15/16] support replication driver in blockdev-add,
Eric Blake <=
- [Qemu-devel] [PATCH 16/16] Add a new API to start/stop replication, do checkpoint to all BDSes, Wen Congyang, 2015/09/02
- [Qemu-devel] [PATCH 14/16] Implement new driver for block replication, Wen Congyang, 2015/09/02