[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 2/2] -help lists only -help-* commands
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v3 2/2] -help lists only -help-* commands |
Date: |
Wed, 2 Sep 2015 11:06:36 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 |
On 08/27/2015 04:22 PM, Laurent Vivier wrote:
> A slight change of behavior:
>
> -help-all displays all helps (like -help/-h before)
> -help/-h lists only the available help commands
I like the change. However, I think that it is missing the overall
summary; bare help should still include the lead-in lines that mention
usage; I'm less concerned if the version line is present (we have
--version for that), but it may be easier to include it too. That is,
this part from pre-patch should probably still show:
$ ./x86_64-softmmu/qemu-system-x86_64 --help
QEMU emulator version 2.4.50, Copyright (c) 2003-2008 Fabrice Bellard
usage: qemu-system-x86_64 [options] [disk_image]
'disk_image' is a raw hard disk image for IDE hard disk 0
Help/version options:
...
>
> Signed-off-by: Laurent Vivier <address@hidden>
> ---
> v3: add this patch to add an help section, -help displays only this section
> qemu-options.hx | 29 +++++++++++++++++++++++++----
> vl.c | 12 +++++++++++-
> 2 files changed, 36 insertions(+), 5 deletions(-)
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH v3 2/2] -help lists only -help-* commands,
Eric Blake <=